This repository was archived by the owner on Dec 11, 2019. It is now read-only.
update site settings for main frame url and use requesting origin in … #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the permission dialog fix #3877 auditors: @bbondy @diracdeltas @mrose17 geoip service must be enabled through GOOGLE_API_KEY GOOGLE_API_ENDPOINT env vars requires brave/muon@f890204
|
this allows us to use the |
|
++ |
| @@ -357,7 +352,7 @@ function registerPermissionHandler (session, partition) { | |||
| {text: locale.translation('deny')}, | |||
| {text: locale.translation('allow')} | |||
| ], | |||
| frameOrigin, | |||
| origin, | |||
There was a problem hiding this comment.
this should be the mainFrameUrl origin
There was a problem hiding this comment.
I guess I'm confused about how this should work. The origin is the origin of the url that is actually requesting the permission. If we used mainFrameUrl here it would appear to the user that the main page is requesting permission when it may actually be requested by a frame with a different origin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Test Plan:
…the permission dialog
fix #3877
auditors: @bbondy @diracdeltas @mrose17
geoip service must be enabled through
GOOGLE_API_KEY
GOOGLE_API_ENDPOINT
env vars
requires brave/muon@f890204