This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
add network connection notifications #3973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notifications will not be fired until electron-prebuilt is updated to brave/muon@b59db72 cc @mrose17
underscore is used throughout `ledger.js`, so no cost in not using `../js/lib/debounce.js`
|
These could be super useful in showing a more meaningful error page when trying to browse offline |
mrose17
added a commit
that referenced
this pull request
Sep 15, 2016
notifications on network up/down to the ledger supercedes #3973
|
superseded by #4038 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notifications will not be fired until electron-prebuilt is updated to brave/muon@b59db72
cc @mrose17
requirement for open ledger issue #??