This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Block script icon is off location when URL bar is hidden #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkup
added
the
design
|
@jkup yup the icons should darken on hover so that it's obvious they are clickable. |
|
lgtm but please re-add the hover darkening |
|
@diracdeltas thanks! updated. |
|
++ thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fix #4007
Test Plan:
Experiment with both bookmarking and blocking scripts on websites and make sure both icons look correct on the top of the browser.
Auditors @diracdeltas @bradleyrichter
Also, @bradleyrichter I noticed some code in there that looks like maybe those icons used to be somewhat see through and then bolden on hover? Is that still desired?