Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Blockscript/Favourite icons look faded #4041

Merged
merged 1 commit into from
Sep 15, 2016
Merged

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Sep 15, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #4035 #4042

Test Plan:

Check that the bookmark icon is filled in orange if bookmarked and not filled in gray when not. Also now the noscript and bookmark icons should both be hidden when not in title mode.

Auditors: @bradleyrichter @diracdeltas

@jkup jkup added this to the 0.12.2dev milestone Sep 15, 2016
@jkup jkup added the design A design change, especially one which needs input from the design team. label Sep 15, 2016
@bradleyrichter
Copy link
Contributor

This will be temporary until we move to the left-end BM position.

noJS will get a new icon and only be shown in the URL box when the URL is visible.

@diracdeltas
Copy link
Member

This PR introduces some design changes that are not covered by #4035 (icons no longer appear at all in titlemode, bookmarks icon is filled in completely in non-titlemode). Please open a new issue for those so QA is aware.

otherwise lgtm

@jkup
Copy link
Contributor Author

jkup commented Sep 15, 2016

@diracdeltas good point! fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants