Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

- History now uses title (not custom title) #4048

Merged
merged 1 commit into from
Sep 17, 2016
Merged

- History now uses title (not custom title) #4048

merged 1 commit into from
Sep 17, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • History now uses title (not custom title)
  • History page also uses cursor: default, to look more app-like

Fixes #4029

Auditors: @bbondy @srirambv

Test Plan:

Part 1

  1. Visit https://clifton.io/about/
  2. Bookmark the site; set the title to "TESTING 123"
  3. Bring up the history page (Ctrl+Y / Cmd+Y)
  4. Verify the entry shows up AND uses the title "About me" (not TESTING 123)

Part 2
5. Move mouse over the table data. Notice it stays as the cursor.

@bsclifton bsclifton added this to the 0.12.2dev milestone Sep 16, 2016
@bbondy
Copy link
Member

bbondy commented Sep 17, 2016

++ but I can't merge currently, could you rebase?

- History page also uses cursor: default, to look more app-like

Fixes #4029

Auditors: @bbondy @srirambv

Test Plan:

Part 1
1. Visit https://clifton.io/about/
2. Bookmark the site; set the title to "TESTING 123"
3. Bring up the history page (Ctrl+Y / Cmd+Y)
4. Verify the entry shows up AND uses the title "About me" (not TESTING 123)

Part 2
5. Move mouse over the table data. Notice it stays as the cursor.
@bsclifton
Copy link
Member Author

updated 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants