This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
removeSite should also remove its children #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave#3763 fix brave#4124 Auditors: @bsclifton Test Plan: 1. Add folder "folder1" under bookmarks toolbar 2. Add folder "folder2" under "folder1" 3. Bookmark "facebook.com" and put it under "folder1" 4. Bookmark "twitter.com" and put it under "folder2" 5. Delete "folder1" 6. "facebook.com" and "twitter.com" should be unstarred
|
Great fix and nice job with the tests 😄 I was just about to ask if you had tried a folder in a folder but then saw them |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).fix #3763
fix #4124
Auditors: @bsclifton
Test Plan: