Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Submenus are now fully navigable via keyboard. #4183

Merged
merged 1 commit into from
Sep 22, 2016
Merged

Submenus are now fully navigable via keyboard. #4183

merged 1 commit into from
Sep 22, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

getMenuItem now searches recursively. Needed to find nested bookmarks when
using the clickMenubarSubmenu window action.

Fixes #4143

Auditors: @bbondy

Test Plan:

  1. Setup your bookmarks so that you have several nested folders containing bookmarks
  2. Launch Brave and hit ALT to engage with the menu
  3. Use arrow keys to move over to Bookmarks menu and press down
  4. Navigate down to your folder and pretty right arrow to go into the folder
  5. Press left arrow to "close" the submenu, returning back a level
  6. Press right/left on an item which is NOT a submenu and notice it changes the menu selection (from File to Edit, for example)

getMenuItem now searches recursively. Needed to find nested bookmarks when
using the clickMenubarSubmenu window action.

Fixes #4143

Auditors: @bbondy
@bbondy bbondy merged commit ff817b1 into brave:master Sep 22, 2016
@bsclifton bsclifton deleted the win-keyboard-submenu branch September 23, 2016 06:44
@luixxiul luixxiul added this to the 0.12.2dev milestone Sep 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows - Keyboard does not work with submenus
3 participants