Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Supersede cd3dd7829731f6e36eb70ac1ac4397598e615153 by "scroll-touch-edge" #4369

Merged
merged 1 commit into from
Oct 4, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Sep 29, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #4499

Auditors: @bbondy

Test Plan:

  1. Open google search result
  2. Click any link and back to the search result
  3. Make the window smaller by open dev console (shift + f8)
  4. Make sure you can horizontally scroll the page
  5. Make sure you can swipe back/forward when you scroll to the edge

Auditors: @bbondy

Test Plan:
1. Open google search result
2. Click any link and back to the search result
3. Make the window smaller by open dev console (shift + f8)
4. Make sure you can horizontally scroll the page
5. Make sure you can swipe back/forward when you scroll to the edge
@darkdh darkdh force-pushed the obsolete-swipe-viewport-solution branch from a21be2b to 58f3fc7 Compare October 4, 2016 14:03
@bbondy
Copy link
Member

bbondy commented Oct 4, 2016

++

@bbondy bbondy merged commit c75353d into brave:master Oct 4, 2016
@bbondy
Copy link
Member

bbondy commented Oct 4, 2016

Please post an issue for this though and tag in 0.12.4 so it gets tested

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supersede old webview horizontal scroll conflict solution
3 participants