Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add npm script to generate sample Publisher visit/duration count (ledger-synopsis.json) #4714

Merged
merged 1 commit into from
Nov 25, 2016
Merged

Add npm script to generate sample Publisher visit/duration count (ledger-synopsis.json) #4714

merged 1 commit into from
Nov 25, 2016

Conversation

willy-b
Copy link
Contributor

@willy-b willy-b commented Oct 12, 2016

Test Plan:

  • Clear Brave user data (npm run clean userData)
  • Run Brave, enable Payments
  • Observe empty synopsis table (no publishers listed)
  • In a terminal, run npm run add-simulated-synopsis-visits
  • Back in Brave, toggle Payments
  • Observe Synopsis table is populated with random Publishers with random visit counts and durations

add_synopsis_visits gif final

This probably should have been part of #4199, my bad.

(We did add simulated payment history, but the issue was more generic than that and my last PR did not generate a browsing synopsis, which this does.)

…ledger-synopsis.json) data

Impl `npm run add-simulated-synopsis-visits` for generating sample browsing synopsis data for testing Ledger features

follow on to #4199
@bsclifton
Copy link
Member

I just ran something similar (add-simulated-payment-history) and it worked great 😄 Thanks!

@bsclifton bsclifton merged commit 9dab193 into brave:master Nov 25, 2016
@luixxiul luixxiul added this to the 0.12.11 milestone Dec 13, 2016
@luixxiul
Copy link
Contributor

@willy-b this does not work for me on macOS. npm run clean userData and npm run add-simulated-synopsis-visits do not update the ledger table. Will you check it out? thanks!

add-simulated-payment-history works for me too :-)

@luixxiul
Copy link
Contributor

After removing ledger-synopsis.json and npm run add-simulated-synopsis-visits, I get this error:

Error: ENOENT: no such file or directory, open '/Users/Suguru/Library/Application Support/brave-development/ledger-synopsis.json'.

What am I missing here?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants