Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix global table indexing #4750

Merged
merged 1 commit into from
Oct 13, 2016
Merged

Fix global table indexing #4750

merged 1 commit into from
Oct 13, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Oct 13, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #4741

Auditors: @bsclifton

Test Plan:

  1. go to about:history
  2. sort the table
  3. multi select entries
  4. right click on them
  5. perform any actions in context menu
  6. the action tagets should be correct

Sorry, something went wrong.

fix brave#4741

Auditors: @bsclifton

Test Plan:
1. go to about:history
2. sort the table
3. multi select entries
4. right click on them
5. perform any actions in context menu
6. the action tagets should be correct
@bsclifton
Copy link
Member

Looks great! Thanks for updating the code to use a custom attribute 😄

@bsclifton bsclifton added this to the 0.12.5dev milestone Oct 13, 2016
@bsclifton bsclifton self-assigned this Oct 13, 2016
@bsclifton bsclifton merged commit 6c04eaf into brave:master Oct 13, 2016
@luixxiul
Copy link
Contributor

Have this fixed #4224 too?

@luixxiul
Copy link
Contributor

follow-up: #4738

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

about:history multi-selection delete does not remove the entries selected
5 participants