This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add new "automatically send usage stats" setting under advanced settings #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sending usage statistics should be off by default. Soon we will invite users to enable it on first launch. Otherwise, it looks OK for 1.0. We may want to remove all of the "(requires browser restart)" and switch to an "*" with footnote at the bottom, after the list. |
…ngs. By default, it's set to false; folks can opt-in by enabling it. Fixes #4691 Auditors: @aekeus @bradleyrichter Test Plan: 1. Open Brave and launch preferences 2. Go under advanced and see new setting (set to false) 3. Set to true and quit Brave 4. Relaunch Brave and open preferences > advanced 5. Setting should be persisted
|
Updated to be off by default 😄 |
|
++ lgtm |
bbondy
reviewed
Oct 17, 2016
| sendCrashReports=Send anonymous crash reports to Brave (requires browser restart) | ||
| sendUsageStatistics=Automatically send usage statistics to Brave |
There was a problem hiding this comment.
@bradleyrichter should we add anonymized or something like that?
|
++ thanks! |
|
merging for 0.12.6 |
This was referenced Oct 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Add new "automatically send usage stats" setting under advanced settings
Currently, nothing uses this new setting. But now that it's there, it can be used by future changes.
Fixes #4691
Auditors: @aekeus @bradleyrichter
Test Plan: