Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Other Bookmarks" folder no longer shows delete in context menu #4857

Merged
merged 1 commit into from
Oct 17, 2016
Merged

"Other Bookmarks" folder no longer shows delete in context menu #4857

merged 1 commit into from
Oct 17, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

"Other Bookmarks" folder no longer shows delete in context menu

Fixes #4836

Auditors: @bbondy

Test Plan:

  1. Launch Brave and open about:bookmarks
  2. Right click "Other Bookmarks" folder
  3. Notice delete and edit are no longer shown

@bsclifton
"Other Bookmarks" folder no longer shows delete in context menu
c898358 
Fixes #4836

Auditors: @bbondy

Test Plan:
1) Launch Brave and open about:bookmarks
2) Right click "Other Bookmarks" folder
3) Notice delete and edit are no longer shown
@bsclifton bsclifton added this to the 0.12.6dev milestone Oct 17, 2016
@bbondy
Copy link
Member

bbondy commented Oct 17, 2016

++ merging for 0.12.6.

@bbondy bbondy merged commit d958d63 into brave:master Oct 17, 2016
@bsclifton bsclifton deleted the other-bookmarks-delete branch October 17, 2016 18:50
This was referenced Oct 20, 2016
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this pull request Oct 22, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bbondy bbondy

Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64
Projects
None yet
Milestone
0.12.6dev
Development

Successfully merging this pull request may close these issues.
4 participants
@bsclifton @bbondy @alexwykoff @srirambv