Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix alignment of home button between tab with content and about:newtab #4870

Closed
wants to merge 1 commit into from
Closed

Fix alignment of home button between tab with content and about:newtab #4870

wants to merge 1 commit into from

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Oct 17, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #4854

Auditors: @jkup @bbondy

@jkup this is a proposed fix which has the same symptom as the favorites button you had adjusted with #4726. This PR should fix it too- basically, it's putting a placeholder button in place (which has opacity 0) which causes the flexbox to adjust it's bounds properly. I'm curious if there's a better solution, but I would need to dig in more (I don't have enough CSS knowledge at the moment to know an alternative)

Test plan:

  1. Launch Brave and open https://brave.com and also a new tab
  2. Open preferences, enable home button
  3. switch between brave.com and the new tab screen. home icon should not move

@bsclifton bsclifton added this to the 0.12.5dev milestone Oct 17, 2016
@bsclifton bsclifton modified the milestones: 0.12.6dev, 0.12.5dev Oct 17, 2016
@bsclifton bsclifton assigned jkup and bbondy and unassigned bbondy Oct 17, 2016
@jkup
Copy link
Contributor

jkup commented Oct 17, 2016

This is interesting, I just asked a question about that line over here #4726 (comment)

Do we even need to render an empty browserButton?

@bsclifton
Copy link
Member Author

Closing in favor of solution provided w/ #4726

@bsclifton bsclifton closed this Oct 18, 2016
@bsclifton bsclifton deleted the fix-button-alignment-newtab branch October 18, 2016 08:45
@luixxiul luixxiul removed this from the 0.12.6dev milestone Oct 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home,Refresh buttons moves up when switching between tabs
4 participants