This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix alignment of home button between tab with content and about:newtab #4870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).Fixes #4854
Auditors: @jkup @bbondy
@jkup this is a proposed fix which has the same symptom as the favorites button you had adjusted with #4726. This PR should fix it too- basically, it's putting a placeholder button in place (which has opacity 0) which causes the flexbox to adjust it's bounds properly. I'm curious if there's a better solution, but I would need to dig in more (I don't have enough CSS knowledge at the moment to know an alternative)
Test plan: