Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

History page now properly opens new tab w/ link that was clicked #4919

Merged
merged 1 commit into from
Oct 18, 2016
Merged

History page now properly opens new tab w/ link that was clicked #4919

merged 1 commit into from
Oct 18, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #4909

Auditors: @darkdh

Test Plan:

  1. Launch Brave and visit a few sites
  2. Visit about:history
  3. Double click one of the entries and confirm it opens the location in a new tab

Fixes #4909

Auditors: @darkdh

Test Plan:
1. Launch Brave and visit a few sites
2. Visit about:history
3. Double click one of the entries and confirm it opens the location in a new tab
@bsclifton
Copy link
Member Author

bsclifton commented Oct 18, 2016

NOTE: I did not see any code change responsible for this. All that was changed was updating the code to use the immutable.js style accessors (versus directly accessing)

@darkdh darkdh self-assigned this Oct 18, 2016
@darkdh
Copy link
Member

darkdh commented Oct 18, 2016

@darkdh
Copy link
Member

darkdh commented Oct 18, 2016

++

@darkdh darkdh merged commit 75c3880 into brave:master Oct 18, 2016
@bsclifton bsclifton deleted the fix-history-doubleclick branch October 18, 2016 23:19
@bbondy
Copy link
Member

bbondy commented Oct 19, 2016

It wasn't because that commit is from 0.116 and this worked in 0.12.4. But probably someone changed the callback handling inside SortableTable or something similar within the last week.

@darkdh
Copy link
Member

darkdh commented Oct 19, 2016

Sorry for the wrong reference. The malfunction started from this commit eea84e5

@bsclifton
Copy link
Member Author

Good find @darkdh, that is indeed it. Unfortunately, this bug exists in 0.12.5 and was shipped ☹️

@bbondy
Copy link
Member

bbondy commented Oct 19, 2016

we were aware just before shipping but decided not to cancel the release yesterday for a respin.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants