This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
URL input field on the bookmark pulldown disappears #4927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).Fix #4897
Auditors @luixxiul @bbondy
Test Plan:
To test, make sure that after clicking the star in the URLbar (both on a currently bookmarked and currently not bookmarked page) you can edit both the name and location without the form changing (i.e the location field disappearing)