Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Normalize the location string for a history item by removing the www. before sorting #4957

Merged
merged 1 commit into from
Oct 20, 2016

Conversation

aekeus
Copy link
Member

@aekeus aekeus commented Oct 19, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Auditors: @bbondy

Test Plan:

  1. Clear session file
  2. Visit twitter.com once
  3. Visit twilio.com once
  4. Close both tabs
  5. Open a new tab and enter the string 'twi'
  6. Ensure www.twilio.com is the first entry (as it was visited most recently and has the same visit count value)

Fixes: #4955

… prefix

before sorting.

Auditors: @bbondy

Test Plan:

  1. Clear session file
  2. Visit twitter.com once
  3. Visit twilio.com once
  4. Close both tabs
  5. Open a new tab and enter the string 'twi'
  6. Ensure www.twilio.com is the first entry (as it was visited most recently and has the same visit count value)

Fixes: #4955
@aekeus aekeus added this to the 0.12.7dev milestone Oct 19, 2016
@aekeus aekeus self-assigned this Oct 19, 2016
@aekeus aekeus modified the milestones: 0.12.6dev, 0.12.7dev Oct 20, 2016
@bbondy
Copy link
Member

bbondy commented Oct 20, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants