This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Updated pluralization in bravery panel (shields panel) to handle 0, 1, or more than 1 #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the l10n properties files have support for this with something like:
|
|
We have an in code example here: |
|
@bbondy this is great, thanks! 😄 working on a fix now... |
…, or more than 1 Also- Hardened tests quite a bit for the Bravery Panel. This includes - added new helpers for: - waitForTabCount - openBraveMenu - waitForDataFile - added waitForTabCount in places where race condition was present - increase timeout for the waitForDataFile portion, which sometimes took longer than 1 second - added a logVerbose method to many helper methods. Can be toggled by setting variable "logVerboseEnabled" to true in `test/lib/brave.js` Fixes #4966 Auditors: @bbondy Test Plan: 1. Launch Brave, go to https://clifton.io, and open bravery panel 2. Notice that: - "Ad or Tracker blocked" is used instead of the plural (since only 1 is present) - items with 0 use the plural tense 3. Visit https://brianbondy.com and notice: - "Ads or Trackers blocked" is used since there are 3 present
|
Updated and ready for re-review 😄 (sorry about the multiple rebases; wanted to make sure it's nice and clean) |
bbondy
reviewed
Oct 20, 2016
| @@ -13,6 +13,14 @@ chai.use(chaiAsPromised) | |||
|
|
|||
| const Server = require('./server') | |||
|
|
|||
| // toggle me for more verbose logs! :) | |||
| const logVerboseEnabled = false | |||
There was a problem hiding this comment.
Please document this in the docs/tests.md
bbondy
reviewed
Oct 20, 2016
| .windowByUrl(Brave.browserWindowUrl) | ||
| // .tabByIndex(0) | ||
| // .loadUrl(url) | ||
| // .url(url) |
|
looks great, thanks. |
This was referenced Oct 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Updated pluralization in bravery panel (shields panel) to handle 0, 1, or more than 1
Also-
Hardened tests quite a bit for the Bravery Panel. This includes
test/lib/brave.jsNOTE: tests are not included for these strings. I can either add them or create an issue to track this
Fixes #4966
Auditors: @bbondy
Test Plan: