This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Show bookmarks in history auto-complete #5084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bookmark sites are by definition also history items. Removing them from the history section of the auto-complete causes them not to be selected when a matching auto-complete term is entered. This commit fixes that behaviour. Auditors: @bbondy Test Plan: (Courtesy of @Sh1d0w) * Visit github.com several times and confirm it appears under History section in url bar suggestions * Bookmark it and confirm it properly appears under bookmarks section in url bar suggestions * Now from settings disable "Show bookmarks suggestions" for the autocomplete * Type github.com in the url bar and ensure it appears under history section as it should Fixes: #5024
|
++ |
This was referenced Oct 26, 2016
This was referenced Oct 27, 2016
This was referenced Oct 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Bookmark sites are by definition also history items. Removing them from the
history section of the auto-complete causes them not to be selected when
a matching auto-complete term is entered.
This commit fixes that behaviour.
Auditors: @bbondy
cc @bradleyrichter
Test Plan: (Courtesy of @Sh1d0w)
Fixes: #5024