Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

display verified badge for verified publishers #5108

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Oct 25, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Auditors @bbondy @bradleyrichter

Fix #3467

Test Plan:

I don't have a real way to test this yet as the verified status isn't coming down from the ledger but ideally you'd visit a "verified" site like brianbondy.com and then when you look in the payments tab of settings you'll see a little green circle with a white checkbox in it.

If you'd like to test it you can just set verified to true in https://github.com/brave/browser-laptop/blob/verified-badge/js/about/preferences.js#L251 (then you'll see it for all publishers)

screen shot 2016-10-24 at 8 56 32 pm

@jkup jkup added this to the 0.12.7dev milestone Oct 25, 2016
@jkup jkup added design A design change, especially one which needs input from the design team. feature/rewards labels Oct 25, 2016
@jkup
Copy link
Contributor Author

jkup commented Oct 25, 2016

Now that wallet creation is fixed, this code works and can be tested/shipped!

cc @bbondy

@bbondy
Copy link
Member

bbondy commented Oct 25, 2016

++

@bbondy bbondy merged commit cc823ac into master Oct 25, 2016
@mrose17
Copy link
Member

mrose17 commented Oct 25, 2016

looks fine to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-macOS QA/checked-Win64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants