Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave crashes when Copy recovery key is clicked during wallet creation #5174

Merged
merged 1 commit into from
Oct 27, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Oct 27, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Auditors @bbondy @bsclifton

Fix #4980

This makes it so advanced settings only shows once the wallet has been created as opposed to once payments are enabled.

Test Plan:

  • Do a clean install
  • Enable payments
  • Make sure advanced settings button is hidden until after the wallet is created

@bsclifton
Copy link
Member

++ LGTM 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants