This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Context menu now works on sortableTable with no selection #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
changed the title
bsclifton
commented
Oct 27, 2016
| @@ -16,9 +16,13 @@ class AddEditBookmark extends ImmutableComponent { | |||
| onClose () { | |||
| windowActions.setBookmarkDetail() | |||
| } | |||
| componentDidMount () { | |||
There was a problem hiding this comment.
this and the change in addEditBookmarkHanger.js are changes I missed when originally doing that control, which was submitted with #5118
Focus is now properly set to the title input box when the modal launches (no issue had been filed yet)
Auditors: @bsclifton Test Plan: 1. go to "about:history" 2. do not select anything 3. right click on an arbitrary entry 4. context menu should show
|
++ thanks for the assist! 😄 |
This was referenced Oct 28, 2016
|
Did this fix #4811 too? It seems so. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Context menu now works on sortableTable with no selection
Also fixes: focus for new folder / edit folder / new bookmark now set properly
Fixes #5202
Auditors: @darkdh
Test plan: