Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix clearing the findbar #5248

Merged
merged 1 commit into from
Oct 30, 2016
Merged

Fix clearing the findbar #5248

merged 1 commit into from
Oct 30, 2016

Conversation

cndouglas
Copy link

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. Navigate to any page and open the findbar.
  2. Type in any word on the current page.
  3. Click the clear button.
  4. Make sure 1) the text field is empty, 2) the number of matches is gone, and 3) the highlighted terms found on the page are gone.

Fixes #5247

@bbondy
Copy link
Member

bbondy commented Oct 30, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants