This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Insert virtual history items for sites like www.google.ca in auto-suggestion url #5278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).When a site is visted for a deep linked page or with parameters
the history item is stored with the complete parameters and links.
Often after a user visits the site a number of times, the expectation
shifts such that the simple domain should be the first suggestion
in the url bar suggestion list. The canonical example is when a
user searches Google a number of times via the url bar. After three
searches www.google.com will be added as a virtual history item in the
search results.
Auditors: @bbondy, @BradRichter
Test Plan:
Fixes: #5067