This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Undefined properties and nested folders handling #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
force-pushed
the
context-menus-refined
branch
from
8970035 to
64d594e
Compare
bridiver
reviewed
Oct 31, 2016
| @@ -1093,7 +1093,8 @@ function mainTemplateInit (nodeProps, frame) { | |||
| }) | |||
|
|
|||
| const passwordManager = getActivePasswordManager() | |||
| if (passwordManager.get('extensionId')) { | |||
| if (passwordManager.get('extensionId') && | |||
| passwordManager.get('displayName') === 'Dashlane') { | |||
There was a problem hiding this comment.
why is this only for dashlane?
There was a problem hiding this comment.
because dashlane doesn't create context menus and other's do which cause repeated entries shows in #5291
There was a problem hiding this comment.
we can just remove these then. The only reason we created context menus for the password managers was because we didn't have contextMenu api support.
fix #5291 fix #5293 requires brave/muon#85 Auditors: @bridiver, @bbondy Test Plan: 1. Go to about:preferences#security 2. Select Lastpass as password manager 3. Login to Lastpass 4. Right click to show context menu 5. Nested menu of Lastpass should show
darkdh
force-pushed
the
context-menus-refined
branch
from
64d594e to
6fb27a1
Compare
|
++ |
This was referenced Nov 2, 2016
This was referenced Nov 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).fix #5291
fix #5293
requires brave/muon#85
Auditors: @bridiver, @bbondy
Test Plan:
Screen shots
brave
chrome
