Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Command+F should close the pulldown on the URL bar Fixes #5340 #5344

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Command+F should close the pulldown on the URL bar Fixes #5340 #5344

merged 1 commit into from
Nov 2, 2016
+3 −0

Conversation

Sh1d0w
Copy link

@Sh1d0w Sh1d0w commented Nov 2, 2016 •
edited
Loading

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@bbondy

@bbondy
Copy link
Member

bbondy commented Nov 2, 2016

would be nice to have a test for this if you don't mind. I'll merge for now though thanks.

@bbondy bbondy merged commit f9067aa into brave:master Nov 2, 2016
@bbondy
Copy link
Member

bbondy commented Nov 2, 2016

The findbar tests are currently in frameTest.js

@Sh1d0w Sh1d0w deleted the hotfix/suggestions-searching-fix branch November 2, 2016 12:07
@luixxiul luixxiul added this to the 0.12.9dev milestone Dec 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature/findbar feature/URLbar
Projects
None yet
Milestone
0.12.9dev
Development

Successfully merging this pull request may close these issues.
3 participants
@Sh1d0w @bbondy @luixxiul