Commits on Nov 4, 2016

1. Created session helper for newTabState …

   - site will only be added if it's a bookmark or history item
   - site will only be removed if it's a bookmark or history item
   - site moves are now ignored
   - favicon is now updated for the newTabState (which is a different list than AppState.sites)
   
   Fixes #5357
   Fixes #5310
   
   Auditors:
   @bridiver - check out the new session helper; hope I did this right :)
   
   @darkdh - this fixes the folder delete issue by ignoring folders
   
   @cezaraugusto - move is no longer tracked (which is fine; we don't care about the order of
   the items with regard to their position in bookmarks toolbar, which is what moveSite is for).
   Also, see the new session helper (which we can use for ordering by # visits)
   
   Test Plan:
   1. Launch Brave and visit brave.com
   2. Open a new tab (about:newtab) and confirm you see brave.com there (favicon should show also)
   3. Visit about:history and delete the visit you just made to brave.com
   4. Confirm it's now gone in about:newtab

   

   bsclifton committed Nov 4, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 729970f
   • Browse repository at this point

   Copy the full SHA

   729970f View commit details

   Browse the repository at this point in the history

2. Added test cases for all methods …

   Auditor: @bridiver

   

   bsclifton committed Nov 4, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for a0e1820
   • Browse repository at this point

   Copy the full SHA

   a0e1820 View commit details

   Browse the repository at this point in the history