issue-keyword tooltipped tooltipped-se" aria-label="This commit closes issue #5337.">Fix #5337 Auditors: @bsclifton @bbondy /cc @luixxiul @srirambv Our topSites grid have actions connected to each other (pinning/removing/reordering), so we must ensure all of them are working properly while doing multiple actions. Test Plan: * Access new tab page; * Access several websites (you can grab this JSON https://github.com/cezaraugusto/brave-json/blob/master/newtab-3-rows.json and copy/paste on session-store-1, it has 18 sites); * Reordering a tile should work on any position; * Pin a site. Pinning a site should add a Pin icon on top-right corner and be kept on its position (not jump); * Keep in mind the website position and reorder it to a new position; * Access another website and get back to new tab. Ensure that your last pinned website kept its position; * Remove that site (pinned or not); * A modal will open. "Undo" removing; * There should be no pinned icon; * Website should be back to its last position; * Pin several websites; * Reorder pinned websites; * Access a new website; * Go back to new tab page: pinned sites should remmember their positions; * Remove a website on removal modal and hit "restore all"; * All sites must be unpinned.

Commits

Commits on Nov 4, 2016

Fix gridLayout pinning action bug