Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

payments advanced settings button hidden when payments disabled #5407

Merged
merged 1 commit into from
Nov 5, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Nov 4, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #5384

Auditors @bbondy @bsclifton

Test Plan:

  1. Go to Preferences > Payments
  2. You should not see the advanced settings button
  3. Enable Payments
  4. You should see the advanced settings button
  5. Disable Payments
  6. You should not see the button

@bbondy
Copy link
Member

bbondy commented Nov 4, 2016

moving to 0.12.9.

@bbondy bbondy modified the milestones: 0.12.9dev, 0.12.8dev Nov 4, 2016
@jkup jkup force-pushed the advanced-settings-button branch from 9637fad to 7e0d8ed Compare November 4, 2016 21:27
@bsclifton bsclifton self-assigned this Nov 5, 2016
@bsclifton
Copy link
Member

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants