refined string text for multiple items including change of Bravery to Shields

[bradleyrichter]

cc @bbondy

[bsclifton]

There were conflicts; I rebased and resolved them. So changes look like:

• remove global site settings from Bravery menu
• move import/check for update down a few positions in mac Brave menu
• Changing text to say "Shield settings" rather than "Bravery settings"
• Add "(will break many sites)" warning to no script

Changes LGTM 😄 Assigning to @bbondy per Brad's comment above

[bradleyrichter]

thanks @bsclifton

[bbondy]

nit: Comment should be aligned with the lines on the same indent level
nit2: You don't ever really need to comment out code since all code is recoverable with git history.

[bbondy]

++ merging.

[bradleyrichter]

Noted. Ty.

On Nov 8, 2016, at 6:04 AM, Brian R. Bondy notifications@github.com wrote:

@bbondy commented on this pull request.

In js/contextMenus.js:

@@ -683,7 +683,7 @@ function hamburgerTemplateInit (location, e) {
}, {
label: locale.translation('bravery'),
submenu: [

•    CommonMenu.braveryGlobalMenuItem(),
  

  +// CommonMenu.braveryGlobalMenuItem(),
  nit: Comment should be aligned with the lines on the same indent level
  nit2: You don't ever really need to comment out code since all code is recoverable with git history.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.