This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Update default for magic titlebar on Windows/Linux; add favicon for about pages #5443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bout:autofill + about:passwords Auditors: @BradRichter, @darkdh Fixes #5416 (URL bar duplicates the title bar) 1. Install Brave (fresh install or move session folder) on Linux 2. Launch Brave and visit brave.com 3. URL bar should always be showing 4. Go to about:preferences and ensure "Always show URL bar" is enabled 1. Install Brave (fresh install or move session folder) on Windows 2. Launch Brave and visit brave.com 3. URL bar should be hidden unless mouse is in there 4. Go to about:preferences and ensure "Always show URL bar" is disabled Fixes #5398 (about:autofill missing Brave favicon) 1. Launch Brave and visit about:about 2. Click about:passwords and notice the favicon now shows up 3. Click about:autofill and notice the favicon now shows up
bsclifton
changed the title
|
++ |
|
Just updated the Windows setting 😄 so after this is merged, new Windows users will get to experience the magic titlebar! (which is great, since the slim titlebar is finished and working well) |
|
I didn't even realize we didn't have it on Windows, hah. |
This was referenced Nov 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran
git rebase -ito squash commits (if needed).Update default value for magic titlebar
add favicon for about pages for which it was missing
Auditors: @BradRichter, @darkdh
Fixes #5416 (URL bar duplicates the title bar)
part 1: linux
part 2: windows
NOTE: this PR does NOT fix #2301; keep that in mind when testing. Windows may have the correct setting, but still show the URL bar☹️
Fixes #5398 (about:autofill missing Brave favicon)