Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix search icon overlapping custom search engine icon #5479

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Fix search icon overlapping custom search engine icon #5479

merged 1 commit into from
Nov 8, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix search icon overlapping custom search engine icon

Auditors: @bbondy

Test Plan:

  1. Launch Brave and open a new tab
  2. Confirm that magnifying glass shows
  3. Type into URL bar, confirm it stays as magnifying glass
  4. Use a search shortcut, like :m, and type this into the URL bar. For example :m date
  5. magnifying glass should disappear and it should show the MDN icon

Fixes #5477
Accidental regression caused by #5449
Includes webdriver test to enforce the expected behavior

Auditors: @bbondy

Test Plan:
1. Launch Brave and open a new tab
2. Confirm that magnifying glass shows
3. Type into URL bar, confirm it stays as magnifying glass
4. Use a search shortcut, like :m, and type this into the URL bar. For example `:m date`
5. magnifying glass should disappear and it should show the MDN icon
@bbondy
Copy link
Member

bbondy commented Nov 8, 2016

++ thanks, and thanks for the extra test too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants