This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
[WIP] Use Electron event to set urlbar security state #5501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
commented
Nov 9, 2016
| @@ -30,9 +30,8 @@ class UrlBarIcon extends ImmutableComponent { | |||
| */ | |||
| get isInsecure () { | |||
| return this.props.isHTTPPage && | |||
| !this.props.isSecure && | |||
| this.props.isSecure === false && | |||
There was a problem hiding this comment.
[note] if isSecure is null, we should show neither secure nor insecure
diracdeltas
commented
Nov 9, 2016
| !this.props.active && | ||
| this.props.loading === false && |
There was a problem hiding this comment.
this was no longer needed because security state is set to null when the load starts
Requires brave/muon#90 Fix #5238 Auditors: @bsclifton @darkdh Test Plan: 1. go to http://dev.ruby.sh/bpoc.html and it should not show up as secure TODO: add automated test for the hackerone issue
diracdeltas
force-pushed
the
fix/security-state
branch
from
f7e4de5 to
058865a
Compare
|
@darkdh this seems to cause a problem with https://mixed-script.badssl.com/ - the icon should show up as insecure after scripts are allowed but it still shows up as secure. seems like a timing issue |
|
And this seems broken too |
|
@darkdh did you try with the latest electron which is just updated right now? 1.4.24? |
|
merging for preview-1 builds. |
|
sorry my bad. It works fine with 1.4.24 |
This was referenced Nov 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Requires brave/muon#90
Fix #5238
Auditors: @bsclifton @darkdh
Test Plan:
TODO: add automated test for the hackerone issue