This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
English locale will now show a smaller version of AM/PM #5520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5381 Auditors: @cezaraugusto Test Plan: 1. Set your locale in Preferences to be English (U.S.) 2. Visit about:newtab; AM/PM (if shown for you) should be smaller than the font-size used for the hour/minute
|
++ |
This was referenced Nov 10, 2016
This was referenced Nov 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).NOTE: Ready for merge after 0.12.9 moves to dev-channel 😄
Fixes #5381
Auditors: @cezaraugusto
Test Plan
Screenshots
Japanese (24 hour time; no AM/PM shown)
English (US; shows AM/PM smaller, vertically aligned to top)
