Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix caption button alignment on Windows 7 #5522

Merged
merged 1 commit into from
Nov 10, 2016
Merged

Fix caption button alignment on Windows 7 #5522

merged 1 commit into from
Nov 10, 2016

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Nov 9, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Properly fixes #5069
(help needed manually testing- my VM is having issues)

Auditors: @bbondy, @jonathansampson

Test Plan:

  1. Launch Brave on Windows 7
  2. Look at the caption buttons; verify positioning looks OK (there may be rendering bugs, but those already exist)
  3. Maximize window and ensure positioning is staying correct

Properly fixes #5069
(help needed manually testing- my VM is having issues)

Auditors: @bbondy, @jonathansampson

Test Plan:
1. Launch Brave on Windows 7
2. Look at the caption buttons; verify positioning looks OK (there may be rendering bugs, but those already exist)
3. Maximize window and ensure positioning is staying correct
@bsclifton
Copy link
Member Author

Manually tested, worked great- will merge but would appreciate any feedback 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine the Brave button (look, positioning, feel) on Windows
5 participants