This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually I'd prefer this, because there would/could be other buttons added and the buttons name could be changed.
|
luixxiul
added
the
design
A design change, especially one which needs input from the design team.
label
Nov 16, 2016
@luixxiul Great! We can close this if you want to submit a PR with that code. |
You can create another commit, squash two commits, and git push -f to overwrite the commit above. |
OK, will do. |
cndouglas
changed the title
Animate fadeIn of reload, stop, and home buttons
Animate fadeIn of titlebar buttons
Nov 16, 2016
Done. Works fine based on my testing. |
++ |
Great catch 😄 I tried it out, looks good! |
This was referenced Dec 12, 2016
4 tasks
This was superseded by #6326 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
design
A design change, especially one which needs input from the design team.
feature/navbar
misc/button
QA/no-qa-needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).Test Plan:
Fixes #5664