Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Change hover of bookmark bar items #5668

Merged
merged 2 commits into from
Nov 21, 2016
Merged

Change hover of bookmark bar items #5668

merged 2 commits into from
Nov 21, 2016

Conversation

cndouglas
Copy link

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. Open a new Brave window.
  2. Make sure the bookmarks toolbar is visible (Menubar > Bookmarks > Bookmarks Toolbar).
  3. Add a new bookmark to the bookmarks toolbar, if necessary.
  4. Move the mouse pointer (hover) over the bookmark item.
  5. Make sure it has a white background with a light gray shadow (like the back and reload buttons).

Fixes #5665.

This matches the hover appearance of the toolbar buttons. Feel free to close if a different appearance is desired.

Matches the hover appearance of the toolbar buttons.

Fixes #5665.
@bbondy
Copy link
Member

bbondy commented Nov 17, 2016

@bradleyrichter pls do a UI review

@cndouglas cndouglas closed this Nov 20, 2016
@cndouglas cndouglas deleted the bookmark-item-hover branch November 20, 2016 00:47
@cndouglas cndouglas restored the bookmark-item-hover branch November 20, 2016 00:47
@cndouglas cndouglas reopened this Nov 20, 2016
@bradleyrichter
Copy link
Contributor

bradleyrichter commented Nov 20, 2016

I added 3 more changes to this but messed up the commit somehow?

23efd25

cc: @bbondy @liunkae

@bradleyrichter
Copy link
Contributor

If we can roll these together, it's good to go! Looks great...

@bsclifton bsclifton added this to the 0.12.11 milestone Nov 20, 2016
@liunkae I adjusted the colors, radius and folder chevron size for this
PR. If it looks good to you, lets call it done.

cc @bbondy
@bsclifton
Copy link
Member

bsclifton commented Nov 20, 2016

cherry-picked Brad's commit into here; looks good to me 😄

Here's a demo screenshot of what it looks like with this PR:
screen shot 2016-11-20 at 4 21 26 pm

Versus what it looks like with the current release (can't see the hover personally)
screen shot 2016-11-20 at 4 22 50 pm

@cndouglas
Copy link
Author

Thanks @bradleyrichter and @bsclifton. Looks great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover background of bookmark bar items is hard to see
5 participants