This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Fix width of input element on New Bookmark Folder form #5837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexwykoff @srirambv @luixxiul could one of you check if this has any other effects especially on other forms? |
|
@bbondy @stefankolb it would be nice if this should fix the bookmark dialog which appears by clicking the star icon next to the URL bar.
|
Fix #5192 Both input elements on the New Bookmark Folder form have the following CSS properties set: * width: 100%; * max-width: 250px; * padding: 0 5px; The default value for box-sizing is content-box (see https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing). This causes the input field for the bookmark folder's title to be 100% + 5px + 5px (width + padding left + padding right) wide. However, the padding is not applied to the select field for parent folder selection, causing the field to be only 100% wide (without the padding). Using border-box as value for the box-sizing attribute for both form fields renders them at an equal width.
…okmarkForm input" Auditors: @bbondy Test Plan:
|
ok, it's good for review.
|
|
@jkup ready for you to check out 😄 @stefankolb knocked out this request (thanks!) and then @luixxiul had some touchups |
4 tasks
|
The two commits were cherry-picked in #6035 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5192
Both input elements on the New Bookmark Folder form have the following
CSS properties set:
The default value for box-sizing is content-box (see
https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing). This
causes the input field for the bookmark folder's title to be 100% +
5px + 5px (width + padding left + padding right) wide. However, the
padding is not applied to the select field for parent folder selection,
causing the field to be only 100% wide (without the padding).
Using border-box as value for the box-sizing attribute for both form
fields renders them at an equal width.
Test Plan:
screenshot 1:
