This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Replace Payment History CSV export with Contribution Statement PDF (rebased) #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
replaces CSV export in Payment History with PDF export Fixes #4769
- add page break every 20 publishers - different info box messages per page (as in spec) - add page legend (N of M) - "Contribution Time" now uses 12 hour format, consistent with display of AM/PM - added gap between two columns of Summary table on first page - added a spacing row to bottom of the contribution detail table on each page - remove log lines fixes #4769
… of about:preferences - contribution statement uses localized strings (only added for en-US for now) - JS moved to new file: js/about/contributionStatement.js - CSS moved to new file: less/contributionStatement.less - added statement date range above the publisher detail table e.g. "October 15th at 6:00pm - November 15th at 4:00 pm" nits - got rid of react warnings (triggered by forceUpdate being called before a setState) - fix  character in front of copyright in Contribution Statement - fix contribution statement wrong filename issue - increased font sizes across board to better use page space - added "=" between verified icon and text definition - fixed "Site" capitalization in publisher table header row - explicitly define page part ordering in CSS using "-webkit-box" and "-webkit-box-ordinal-group" - increase spacing of lines in publisher detail table for aiding development - a single contribution statement can be loaded by navigating to "about:contributions[#VIEWING_ID]" - all statements are also listed at "about:contributions" - Note: "about:contributions" is hidden from "about:about" list fixes #4769
- moved ledgerExportUtil / ledgerExportUtilTest to new location - moved exampleLedgerData to fixtures directory - updated style of ledgerExportUtil to be more consistent with rest of codebase - added tests for new sort functionality - tweak to fix JavaScript error I got when testing
|
I rebased to squash the commits I had made and added the autoclosing keywords (ex: "fixes") Giving this one last spin locally before accepting... also will look at the automated tests 😄 |
|
tests failed for some reason (they didn't even start to run); but locally, they ran great 😄 Merging! |
This was referenced Dec 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of work reviewed in PR #4771 and replaces it. Implements #4769.
git rebase -ito squash commitsTest Plan:
npm run add-simulated-payment-historyScreencap:
