Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removed the hacks of the buttons on the navigation bar (for Windows) #5967

Merged
merged 1 commit into from
Dec 1, 2016
Merged

Removed the hacks of the buttons on the navigation bar (for Windows) #5967

merged 1 commit into from
Dec 1, 2016

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Dec 1, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #5928

Thanks to #5739 and #5750 (#5737) these hacks are no longer necessary.

Auditors: @srirambv @bsclifton

Test Plan:

  1. Enable Home Button
  2. Open some pages in the same tab to enable backButton and forwardButton
  3. Make sure every place of the buttons are clickable
  4. Make sure height and width of the buttons remain the same (34x24, 26x24)
  5. Make sure stopButton is centered
  6. Make sure the bookmark icon is properly aligned on each platforms

Sorry, something went wrong.

Unverified

No user is associated with the committer email.
Fixes #5928

Thanks to #5739 and #5750 (#5737) these hacks are no longer necessary.

Auditors: @srirambv

Test Plan:
1. Enable Home Button
2. Open some pages in the same tab to enable backButton and forwardButton
3. Make sure every place of the buttons are clickable
4. Make sure height and width of the buttons remain the same (34x24, 26x24)
5. Make sure stopButton is centered
6. Make sure the bookmark icon is properly aligned on each platforms
@luixxiul
Copy link
Contributor Author

luixxiul commented Dec 1, 2016

With the commit it should be like this on Windows:
clipboard01

@bradleyrichter
Copy link
Contributor

@luixxiul I am having de ja vu here. Is this a PR to fix an unwinding of your older PR that already fixed this? Or did that one never make it in?

@luixxiul
Copy link
Contributor Author

luixxiul commented Dec 1, 2016

@bradleyrichter At that time I was not sure of the hacks for Windows, which I removed with the commit. If you are having the de ja vu, I think it's good to go :-)

@bradleyrichter
Copy link
Contributor

perfect!

@bsclifton bsclifton self-assigned this Dec 1, 2016
@bsclifton
Copy link
Member

looks beautiful! great job 😄

image

@bsclifton bsclifton merged commit b0eb54e into brave:master Dec 1, 2016
@luixxiul luixxiul deleted the fix-hacksForWindows-navigationBar branch December 2, 2016 01:21
@bbondy
Copy link
Member

bbondy commented Dec 2, 2016

love it :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants