This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add zoom shortcut support. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take over this branch unless you're already working on it. |
|
I think there's just a problem loading the webview preload path, maybe something wrong with webpack. Go ahead and finish this for me if you can, thanks! |
|
yep there was a problem with needing it in webpack and also event names were wrong in the preload script. But there's a third problem too, will fix. |
Closed
30 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not working yet, possibly a problem with needing a new webpack entry for the preload script?