This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
Restyled select and input to the spec image #6084
Closed
Closed
Commits on Dec 14, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 3d75ed6 - Browse repository at this point
Copy the full SHA 3d75ed6View commit details
Commits on Dec 21, 2016
-
Configuration menu - View commit details
-
Copy full SHA for ee5b184 - Browse repository at this point
Copy the full SHA ee5b184View commit details
Commits on Jan 9, 2017
-
Making the Clear Browsing Data panel stateful
Majorly, the change affects 2 places in the UI. The Clear Browsing Data… option in the History menu and the Clear Browsing Data Now… button in the Security tab in Preferences. We store the state of the toggled options when the user clears anytime, so that the next time he/she opens this dialog, the options are pre-populated as per the last selected options From a technical perspective, we have moved away from saving the current state of the SwitchControls in the windowState. We only save the visibility on the windowState. The whole state is managed by the panel itself and just updates the appState on clicking clear. Fixes #4082
Configuration menu - View commit details
-
Copy full SHA for 11633da - Browse repository at this point
Copy the full SHA 11633daView commit details
Commits on Jan 10, 2017
-
Merge pull request #6026 from maaz93/new-history-state
Making the Clear Browsing Data panel stateful
Configuration menu - View commit details
-
Copy full SHA for e5fc2ba - Browse repository at this point
Copy the full SHA e5fc2baView commit details
Commits on Jan 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 0f0fc38 - Browse repository at this point
Copy the full SHA 0f0fc38View commit details -
Merge pull request #6101 from brave/prefs-payments
restyle preferences payments
Configuration menu - View commit details
-
Copy full SHA for 2161945 - Browse repository at this point
Copy the full SHA 2161945View commit details -
Merge pull request #6037 from brave/add-focus-ring
Add focus ring to about page form elements
Configuration menu - View commit details
-
Copy full SHA for d3759ba - Browse repository at this point
Copy the full SHA d3759baView commit details -
Merge pull request #6359 from Liunkae/paste-unformatted-context-menu
Add Paste Without Formatting to context menu
Configuration menu - View commit details
-
Copy full SHA for dd64f4d - Browse repository at this point
Copy the full SHA dd64f4dView commit details -
Restyled select and input element to the spec images
Closes #5972 - Set -webkit-appearance:none - Set the caret down SVG file (created by @bradleyrichter) as the background-image - Set the outline inside the input element - Set height:2rem to make the height consistent - Moved properties in .form-control to the input and select element - Removed box-shadow properties from the input and select element under .bookmarkForm - Set specific properties to input in #navigator The caret down SVG file will be replaced with the sprite PNG later (See #5891) Auditors: Test Plan: 1. Open about:preferences 2. Make sure the text entry fields with active edit state have the rectangle inside them 3. Make sure the drop down arrows are styled properly 4. Open another page in a new tab 5. Open the shield from the top right lion icon 6. Make sure the drop down arrows are styled properly 7. Bookmark about:preferences 8. Make sure the input and select elements are styled consistently on the bookmark dialog
Suguru Hirahara committedJan 11, 2017 Configuration menu - View commit details
-
Copy full SHA for fd0c10a - Browse repository at this point
Copy the full SHA fd0c10aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.