Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Restyled select and input to the spec image #6084

Closed
wants to merge 9 commits into from
Closed

Restyled select and input to the spec image #6084

wants to merge 9 commits into from

Commits on Dec 14, 2016

  1. Configuration menu
    Copy the full SHA
    3d75ed6 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2016

  1. Add Paste Without Formatting to context menu

    Fixes #5822
    Liunkae authored Dec 21, 2016
    Configuration menu
    Copy the full SHA
    ee5b184 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2017

  1. Making the Clear Browsing Data panel stateful

    Majorly, the change affects 2 places in the UI. The Clear Browsing
    Data… option in the History menu and the Clear Browsing Data Now…
    button in the Security tab in Preferences. We store the state of the
    toggled options when the user clears anytime, so that the next time
    he/she opens this dialog, the options are pre-populated as per the last
    selected options
    
    From a technical perspective, we have moved away from saving the
    current state of the SwitchControls in the windowState. We only save
    the visibility on the windowState. The whole state is managed by the
    panel itself and just updates the appState on clicking clear.
    
    Fixes #4082
    maazadeeb authored and bsclifton committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    11633da View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2017

  1. Merge pull request #6026 from maaz93/new-history-state

    Making the Clear Browsing Data panel stateful
    bsclifton authored Jan 10, 2017
    Configuration menu
    Copy the full SHA
    e5fc2ba View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2017

  1. restyle preferences payments

    jkup committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    0f0fc38 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #6101 from brave/prefs-payments

    restyle preferences payments
    bsclifton authored Jan 11, 2017
    Configuration menu
    Copy the full SHA
    2161945 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #6037 from brave/add-focus-ring

    Add focus ring to about page form elements
    bsclifton authored Jan 11, 2017
    Configuration menu
    Copy the full SHA
    d3759ba View commit details
    Browse the repository at this point in the history
  4. Merge pull request #6359 from Liunkae/paste-unformatted-context-menu

    Add Paste Without Formatting to context menu
    bsclifton authored Jan 11, 2017
    Configuration menu
    Copy the full SHA
    dd64f4d View commit details
    Browse the repository at this point in the history
  5. Restyled select and input element to the spec images

    Closes #5972
    
    - Set -webkit-appearance:none
    - Set the caret down SVG file (created by @bradleyrichter) as the background-image
    - Set the outline inside the input element
    - Set height:2rem to make the height consistent
    - Moved properties in .form-control to the input and select element
    - Removed box-shadow properties from the input and select element under .bookmarkForm
    - Set specific properties to input in #navigator
    
    The caret down SVG file will be replaced with the sprite PNG later (See #5891)
    
    Auditors:
    
    Test Plan:
    1. Open about:preferences
    2. Make sure the text entry fields with active edit state have the rectangle inside them
    3. Make sure the drop down arrows are styled properly
    4. Open another page in a new tab
    5. Open the shield from the top right lion icon
    6. Make sure the drop down arrows are styled properly
    7. Bookmark about:preferences
    8. Make sure the input and select elements are styled consistently on the bookmark dialog
    Suguru Hirahara committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    fd0c10a View commit details
    Browse the repository at this point in the history