This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Print stack to trace where the warning comes from #6155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
force-pushed
the
cr54-warning-stack
branch
from
2249807 to
c4a7d25
Compare
darkdh
force-pushed
the
cr54-warning-stack
branch
from
c4a7d25 to
a77be92
Compare
bbondy
reviewed
Dec 15, 2016
| @@ -36,6 +36,8 @@ process.on('unhandledRejection', function (error, promise) { | |||
| handleUncaughtError(error) | |||
| }) | |||
|
|
|||
| process.on('warning', warning => console.warn(warning.stack)) | |||
There was a problem hiding this comment.
Maybe we should also print warning.message first?
There was a problem hiding this comment.
But it has already printed name: message + stack. Ex.
DeprecationWarning: Calling an asynchronous function without callback is deprecated.
at maybeCallback (fs.js:95:42)
at Object.fs.appendFile (fs.js:1237:14)
at debug (/Users/darkdh/Projects/browser-laptop-bootstrap2/src/browser-laptop/app/updater.js:30:6)
at Object.exports.updateUrl (/Users/darkdh/Projects/browser-laptop-bootstrap2/src/browser-laptop/app/updater.js:52:3)
at Object.exports.init (/Users/darkdh/Projects/browser-laptop-bootstrap2/src/browser-laptop/app/updater.js:91:25)
at PackageLoader.load (/Users/darkdh/Projects/browser-laptop-bootstrap2/src/browser-laptop/app/index.js:732:15)
at fs.readFile (/Users/darkdh/Projects/browser-laptop-bootstrap2/src/browser-laptop/app/package-loader.js:16:5)
at tryToString (fs.js:425:3)
It would be like this after added
DeprecationWarning
Calling an asynchronous function without callback is deprecated.
DeprecationWarning: Calling an asynchronous function without callback is deprecated.
at maybeCallback (fs.js:95:42)
at Object.fs.appendFile (fs.js:1237:14)
at debug (/Users/darkdh/Projects/browser-laptop-bootstrap2/src/browser-laptop/app/updater.js:30:6)
at AutoUpdater.autoUpdater.on (/Users/darkdh/Projects/browser-laptop-bootstrap2/src/browser-laptop/app/updater.js:246:3)
at emitTwo (events.js:106:13)
at AutoUpdater.emit (events.js:191:7)
at Object.exports.init (/Users/darkdh/Projects/browser-laptop-bootstrap2/src/browser-laptop/app/updater.js:98:19)
at PackageLoader.load (/Users/darkdh/Projects/browser-laptop-bootstrap2/src/browser-laptop/app/index.js:736:15)
at fs.readFile (/Users/darkdh/Projects/browser-laptop-bootstrap2/src/browser-laptop/app/package-loader.js:16:5)
at tryToString (fs.js:425:3)
Plus node's warning message might be too many of them
(node:18561) DeprecationWarning: Calling an asynchronous function without callback is deprecated.
|
ok |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).#5691
Auditors: @mrose17, @bbondy