Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Add the option "Hide sites with less than 1% usage" #6174

Closed
wants to merge 1 commit into from
Closed

Add the option "Hide sites with less than 1% usage" #6174

wants to merge 1 commit into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Dec 13, 2016 •
edited
Loading

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Addresses #4681

  • Added variables which seems to me necessary
    • MINIMUM_PERCENTAGE
    • advanced.minimum-percentage
  • Updated preferences.less to implement the switch

The width of the advanced settings modal window will be was fixed after #6047 is merged.

Auditors: @mrose17

Test Plan:

Designed the switch of "Hide sites with less than 1% usage"
6f39925 
Addresses #4681

- Added variables which seems to me necessary
  - MINIMUM_PERCENTAGE
  - advanced.minimum-percentage
- Updated preferences.less to implement the switch

The width of the advanced settings modal window will be fixed after #6047 is merged.

Auditors: @mrose17

Test Plan:
mrose17 added a commit that referenced this pull request Dec 14, 2016
@mrose17
Add the option "Hide sites with less than 1% usage"
9bfaff5 
Auditor: @bsclifton

Fixes #4681

Based on
https://github.com/luixxiul/browser-laptop/commit/86c875616085f755e5ced0
421e7bdc9b2b9e601b and
#6174, but ported to the
0.12-branch
@mrose17
Copy link
Member

mrose17 commented Dec 14, 2016

addressed by 9bfaff5 (this PR but ported to the 0.12-branch)

@mrose17 mrose17 closed this Dec 14, 2016
@luixxiul
Copy link
Contributor Author

luixxiul commented Dec 14, 2016 •
edited
Loading

@mrose17 thanks for doing this! :-D

Merged in the master branch with this: 8ae8eb4

@luixxiul luixxiul deleted the payment-minimum-percentage branch December 14, 2016 16:18
@luixxiul luixxiul added this to the 0.13.0 milestone Jan 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mrose17 mrose17

Labels
feature/rewards
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@luixxiul @mrose17