This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix immutable.getIn and autofillPopupHidden condition #6234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
reviewed
Dec 15, 2016
| if (windowState.getIn('contextMenuDetail', 'type') === 'autofill' && | ||
| windowState.getIn('contextMenuDetail', 'tabId') === action.tabId) { | ||
| if (windowState.getIn(['contextMenuDetail', 'type']) === 'autofill' && | ||
| windowState.getIn(['contextMenuDetail', 'tabId']) === action.tabId) { |
There was a problem hiding this comment.
woops, it'd be nice to lint for this type of error eventually.
There was a problem hiding this comment.
this is probably the reason the code above was still needed. I think we can keep this and lose the isFocused check
|
++ |
bridiver
reviewed
Dec 15, 2016
| @@ -688,7 +688,10 @@ class Frame extends ImmutableComponent { | |||
| contextMenus.onShowAutofillMenu(e.suggestions, e.rect, this.frame) | |||
| }) | |||
| this.webview.addEventListener('hide-autofill-popup', (e) => { | |||
| windowActions.autofillPopupHidden(this.props.tabId) | |||
| let webContents = this.webview.getWebContents() | |||
There was a problem hiding this comment.
this shouldn't be necessary anymore. I changed windowStore to make a check instead. I think we may want to revert this unless I'm missing something
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Test Plan: Covered by auto test
fix #6233
Auditors: @bridiver, @bbondy