Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed the bookmark hanger being faded in #6382

Closed
wants to merge 1 commit into from
Closed

Fixed the bookmark hanger being faded in #6382

wants to merge 1 commit into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Dec 22, 2016

Fixes #6380

Auditors:

Test Plan:

  1. Bookmark a page with the star icon on the URL bar
  2. Make sure "Bookmark Added" dialog is instantly prompt without animation
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

unintentionally I broke the animation. I've been not sure that the bookmark dialog was included in #navigator.

@luixxiul luixxiul added this to the 0.13.0 milestone Dec 22, 2016
@luixxiul luixxiul self-assigned this Dec 22, 2016
@luixxiul luixxiul removed their assignment Dec 22, 2016
@luixxiul luixxiul removed the request for review from bsclifton December 22, 2016 15:48
@luixxiul luixxiul removed this from the 0.13.0 milestone Dec 22, 2016
@bsclifton bsclifton added this to the 0.13.1 milestone Dec 26, 2016
@bsclifton
Copy link
Member

@jkup would you be able to check this one out? If it looks good, let's mark with a ready-for-merge (but don't actually merge it yet)

@bsclifton bsclifton requested a review from jkup December 26, 2016 04:49
@jkup
Copy link
Contributor

jkup commented Dec 26, 2016

Not crazy about that selector, it's a bit tough to read. If we're going to keep the wildcard + :not selector can we at least add a comment that says something like:

/* Animate all direct descendants except for the bookmark bar */

Just something to make it easier for the next dev to understand! Otherwise ++

@luixxiul
Copy link
Contributor Author

luixxiul commented Dec 27, 2016

ok updated, thanks.

@jkup
Copy link
Contributor

jkup commented Dec 27, 2016

thanks @luixxiul ++

@luixxiul luixxiul changed the base branch from master to 0.13.1-branch January 11, 2017 06:59
@luixxiul luixxiul removed the request for review from jkup January 14, 2017 04:31
@luixxiul
Copy link
Contributor Author

I'll rebase

Fixes #6380

Auditors:

Test Plan:
1. Bookmark a page with the star icon on the URL bar
2. Make sure that "Bookmark Added" dialog is instantly displayed without animation
@luixxiul
Copy link
Contributor Author

I close this PR since it doesn't use Aphrodite:
https://github.com/brave/browser-laptop/wiki/Reviewer-guideline

@luixxiul luixxiul removed this from the 0.13.1 milestone Jan 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants