Export bookmarks

[NejcZdovc]

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).

Resolves #1002

Auditors

@bbondy @bsclifton

Test Plan

Moved to #1002 (comment)

Automated tests

• npm run watch-test
• npm run unittest -- --grep="Bookmarks export"

[luixxiul]

Sweet! love to see this implemented soon :-)

[bbondy]

@NejcZdovc would you mind rebasing this PR? Thanks!

[NejcZdovc]

@bradleyrichter added new icons.

[bradleyrichter]

@NejcZdovc Can you try adding some padding between them? About 5 px or equivalent.

And what is the best way to get our mouse-hover highlight to work? Use CSS with the SVG?

[NejcZdovc]

@bradleyrichter I was just updating padding when you wrote about it 😃 We are doing hover with CSS.

New layout (changed from 7px to 10px)

If I need to add some more padding please let me know

[bradleyrichter]

ha ha...

Now I see that the new folder button looks bigger than the import/export. Can you try enlarging the import/export buttons?

[luixxiul]

I started feeling a bit that the import and export icons should not be on the "Folders" row (because it is not the folders that are to be imported or exported); instead right or left of the search form would be better. wdyt @bradleyrichter ?

[NejcZdovc]

@bradleyrichter icons are aligned, maybe it's an optical thing?

[NejcZdovc]

@luixxiul what about on the right side where you have add bookmark icon?

[bradleyrichter]

@luixxiul I think your suggestion is good. It's more hierarchically correct.

Add Bookmark should add a new BM into the currently selected folder so that one seems to be in the right spot.

@NejcZdovc If you can move them easily, and agree that it's clearer, go ahead. Otherwise we can finish and close this PR as is and revisit the location.

[NejcZdovc]

@bradleyrichter @luixxiul I like the new position. It's implemented now. What do you guys think?

[luixxiul]

Looking good 👍 except when you minimize the window:

I'd make an adjustment in a follow up task as that's a minor issue.

[bradleyrichter]

I think I'll have an icon revision soon but functionally it looks good.

…

On Feb 2, 2017, at 9:24 PM, Suguru Hirahara ***@***.***> wrote: Looking good 👍 except when you minimize the window: I'd make an adjustment in a follow up task as that's a minor issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[NejcZdovc]

If you will prepare them before the end of 0.13.3 milestone, I can add it in this PR, otherwise I would merge this PR and add it later.

[bsclifton]

++

[bsclifton]

Most tests passed with CI; those which didn't, I ran locally and verified they work. Feature is good to go! Merging

[StuartWilloughby]

This appears to have broken in 0.19.70. Clicking on Export does not generate a file.