Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Made the entire .bookmarkButtonContainer clickable #6712

Merged
merged 1 commit into from
Jan 26, 2017
Merged

Made the entire .bookmarkButtonContainer clickable #6712

merged 1 commit into from
Jan 26, 2017

Conversation

luixxiul
Copy link
Contributor

Closes #6704

Auditors:

Test Plan:

  1. Click the star icon to show "Bookmark Added"
  2. Click around the icon to show "Edit Bookmark"
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Closes #6704

Auditors:

Test Plan:
1. Click the star icon to show "Bookmark Added"
2. Click around the icon to show "Edit Bookmark"
@luixxiul luixxiul changed the base branch from master to 0.13.1-branch January 18, 2017 16:24
@luixxiul luixxiul changed the base branch from 0.13.1-branch to master January 18, 2017 16:24
@luixxiul luixxiul changed the base branch from master to 0.13.1-branch January 18, 2017 20:12
@luixxiul luixxiul added this to the 0.13.1 milestone Jan 19, 2017
@bsclifton bsclifton force-pushed the 0.13.1-branch branch 5 times, most recently from 65c7753 to 238cfd3 Compare January 25, 2017 19:19
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 67b2326 into brave:0.13.1-branch Jan 26, 2017
@luixxiul luixxiul deleted the fix-bookmarkButtonContainer branch January 26, 2017 02:19
bsclifton pushed a commit that referenced this pull request Jan 26, 2017
Closes #6704

Auditors:

Test Plan:
1. Click the star icon to show "Bookmark Added"
2. Click around the icon to show "Edit Bookmark"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants