Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Dismiss autofill context menu when tabId is different #6854

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Dismiss autofill context menu when tabId is different #6854

merged 1 commit into from
Jan 25, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jan 25, 2017 •
edited
Loading

fix #6820

Auditors: @bbondy, @bsclifon

Test Plan: Covered by automatic test

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@darkdh darkdh added this to the 0.13.1 milestone Jan 25, 2017
@darkdh darkdh requested review from bbondy and bsclifton January 25, 2017 13:27
@bsclifton bsclifton changed the base branch from master to 0.13.1-branch January 25, 2017 17:16
@bsclifton
Copy link
Member

bsclifton commented Jan 25, 2017 •
edited
Loading

I'm working through some rebasing for this :) hang tight! (since this is for 0.13.1)

@darkdh @bsclifton
Dismiss autofill context menu when tabId is different
11d48ef 
fix brave#6820

Auditors: @bbondy, @bsclifon

Test Plan: Covered by automatic test
@bsclifton
Copy link
Member

@darkdh rebase finished 😄 Does this look correct?

@darkdh
Copy link
Member Author

darkdh commented Jan 25, 2017 •
edited
Loading

@bsclifton , perfect! Thanks.

bsclifton
bsclifton approved these changes Jan 25, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++!

@bsclifton bsclifton merged commit 65c7753 into brave:0.13.1-branch Jan 25, 2017
@bsclifton bsclifton mentioned this pull request Jan 25, 2017
Closed
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@darkdh darkdh

Labels
feature/autofill
Projects
None yet
Milestone
0.13.2
Development

Successfully merging this pull request may close these issues.
2 participants
@darkdh @bsclifton