Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Minimum publisher visit default now 1 #6972

Merged
merged 2 commits into from
Feb 1, 2017
Merged

Minimum publisher visit default now 1 #6972

merged 2 commits into from
Feb 1, 2017

Conversation

mrose17
Copy link
Member

@mrose17 mrose17 commented Feb 1, 2017

Fixes #6941

Test Plan

  1. start the browser with a new session, verify that the advanced settings shows '1' for relevancy
  2. change the value, close the window, open it again, verify the change took.
  3. quit the browser, start the browser, verify the change is still there.

@mrose17 mrose17 added this to the 0.13.3 milestone Feb 1, 2017
@mrose17 mrose17 self-assigned this Feb 1, 2017
@mrose17 mrose17 requested a review from bsclifton February 1, 2017 04:53
@bsclifton bsclifton modified the milestones: 0.13.2, 0.13.3 Feb 1, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add a missing value (see commit), but otherwise LGTM 😄

@bsclifton
Copy link
Member

Proof that it works and that I ran the code:
screen shot 2017-01-31 at 11 15 56 pm

@bsclifton bsclifton merged commit 296c6d6 into master Feb 1, 2017
@bsclifton bsclifton deleted the issue-6941 branch February 1, 2017 06:21
@luixxiul
Copy link
Contributor

luixxiul commented Feb 1, 2017

Note: https://github.com/bsclifton/browser-laptop/commit/95426b6133e4542f7819da0ef36f1328cb1a5149 intends to fix https://travis-ci.org/brave/browser-laptop/builds/197205697#L4681

  9) PaymentsTab component advanced ledger settings content defaults to 5 minimum publisher visits:
     AssertionError: '1' == 5
      at Context.<anonymous> (test/unit/app/renderer/paymentsTabTest.js:222:14)
      at Test.Runnable.run (node_modules/co-mocha/lib/co-mocha.js:43:16)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change "Publisher Relevancy" options and default
3 participants