This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add audio indicators and mute tab functionality #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Dispatches a message to indicate that audio is playing | ||
| * | ||
| * @param true if the frame is playing audio |
There was a problem hiding this comment.
although it's clear that this is referring to audioPlaybackActive, I think we should generally put at least name and type in jsdoc tags. i.e., @param {boolean} audioPlaybackActive - true if ....
|
Cool, lgtm otherwise! |
This adds audio indicators when sound is playing as well as the ability to click on them to mute and unmute audio. You won't actually see any audio indicators until I do another prebuilt build though. I'm going to try to upstream this patch on electron which adds support. brave/muon@dbb0a3b Auditors: @diracdeltas
bbondy
force-pushed
the
audio-indicator-mute-tab
branch
from
e610ea8 to
54a0d75
Compare
bbondy
added a commit
that referenced
this pull request
Dec 20, 2015
Add audio indicators and mute tab functionality
|
Electron patch was merged upstream here: Still need to spin a new brave electron prebuilt build though. |
This was referenced Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds audio indicators when sound is playing as well as the ability
to click on them to mute and unmute audio.
You won't actually see any audio indicators until I do another prebuilt
build though. I'm going to try to upstream this patch on electron which
adds support.
brave/muon@dbb0a3b
Auditors: @diracdeltas